Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support features by parameters #67

Merged
merged 10 commits into from Sep 19, 2019
Merged

Conversation

koxudaxi
Copy link
Owner

@koxudaxi koxudaxi commented Sep 16, 2019

The PR supports all features(type inspection, searching, refactoring...) by parameters which are in a function or methods.

ScreenShots

ss2019-09-20 1 46 15

@codecov
Copy link

codecov bot commented Sep 16, 2019

Codecov Report

Merging #67 into master will decrease coverage by 2.34%.
The diff coverage is 59.09%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #67      +/-   ##
============================================
- Coverage     80.05%   77.71%   -2.35%     
- Complexity       77       80       +3     
============================================
  Files             7        7              
  Lines           356      359       +3     
  Branches        123      127       +4     
============================================
- Hits            285      279       -6     
- Misses           18       25       +7     
- Partials         53       55       +2
Impacted Files Coverage Δ Complexity Δ
...om/koxudaxi/pydantic/PydanticFieldRenameFactory.kt 91.83% <100%> (-2.05%) 11 <0> (-1)
...koxudaxi/pydantic/PydanticCompletionContributor.kt 91.56% <100%> (+6.61%) 1 <0> (ø) ⬇️
...m/koxudaxi/pydantic/PydanticFieldSearchExecutor.kt 67.44% <37.5%> (-23.74%) 21 <3> (+1)
src/com/koxudaxi/pydantic/Pydantic.kt 69.23% <50%> (-8.55%) 0 <0> (ø)
src/com/koxudaxi/pydantic/PydanticTypeProvider.kt 66.99% <53.84%> (+3.44%) 39 <0> (+3) ⬆️
src/com/koxudaxi/pydantic/PydanticInspection.kt 81.48% <60%> (+0.71%) 2 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9232eaf...a3a5536. Read the comment docs.

@koxudaxi koxudaxi force-pushed the suuport_features_by_parameters branch from 5a6d89f to 7daaaa3 Compare September 19, 2019 17:01
fix to handle models which have __init__ or __new__ methods
@koxudaxi koxudaxi force-pushed the suuport_features_by_parameters branch from 7daaaa3 to a021c21 Compare September 19, 2019 17:25
@koxudaxi koxudaxi merged commit 05706d1 into master Sep 19, 2019
@koxudaxi koxudaxi deleted the suuport_features_by_parameters branch September 19, 2019 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant