Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix fisrt parameter type of a validator method #76

Merged
merged 1 commit into from Sep 24, 2019
Merged

Fix fisrt parameter type of a validator method #76

merged 1 commit into from Sep 24, 2019

Conversation

koxudaxi
Copy link
Owner

The PRs fixes first parameter type of a validator method.
The type of parameter should be Class.

eg:

class Model(BaseModel):
    bar: int


    @validator('bar')
    def fa(cls, bar):
        cls  # <- cls is Class

@koxudaxi koxudaxi merged commit 5e89bfd into master Sep 24, 2019
@koxudaxi koxudaxi deleted the fix_fisrt_parameter_type_of_a_validator_method branch September 24, 2019 05:28
@codecov
Copy link

codecov bot commented Sep 24, 2019 •
edited

Codecov Report

Merging #76 into master will decrease coverage by 0.11%.
The diff coverage is 36.36%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #76      +/-   ##
============================================
- Coverage     70.25%   70.13%   -0.12%     
- Complexity       83       85       +2     
============================================
  Files             8        8              
  Lines           437      442       +5     
  Branches        153      157       +4     
============================================
+ Hits            307      310       +3     
  Misses           65       65              
- Partials         65       67       +2
Impacted Files Coverage Δ Complexity Δ
src/com/koxudaxi/pydantic/PydanticTypeProvider.kt 68.42% <36.36%> (-0.39%) 44 <3> (+2)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 62900a4...793225d. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@koxudaxi