Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support dataclass with extension point #98

Merged
merged 12 commits into from Apr 9, 2020

Conversation

koxudaxi
Copy link
Owner

The PR supports a native feature to treat dataclass variants which feature include typing and inspection with PyCharm.

The feature is added in PyCharm since version 2020 EAP or later.
PyCharm provides the feature as an extension point for third-party dataclass variant libraries like Pydantic .

Thanks to @sproshev

Related Issues

#48
JetBrains/intellij-community#1245

@koxudaxi koxudaxi force-pushed the support_dataclass_with_extension_point branch from 03897b1 to fe87afd Compare January 31, 2020 03:20
@codecov
Copy link

codecov bot commented Jan 31, 2020

Codecov Report

Merging #98 into master will increase coverage by 0.58%.
The diff coverage is 72.34%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #98      +/-   ##
============================================
+ Coverage     68.28%   68.87%   +0.58%     
- Complexity       89       93       +4     
============================================
  Files            11       12       +1     
  Lines           637      649      +12     
  Branches        216      216              
============================================
+ Hits            435      447      +12     
  Misses           93       93              
  Partials        109      109              
Impacted Files Coverage Δ Complexity Δ
src/com/koxudaxi/pydantic/PydanticTypeProvider.kt 68.00% <40.00%> (ø) 46.00 <4.00> (ø)
src/com/koxudaxi/pydantic/PydanticInspection.kt 68.11% <42.85%> (ø) 2.00 <0.00> (ø)
...koxudaxi/pydantic/PydanticCompletionContributor.kt 81.87% <57.14%> (ø) 1.00 <0.00> (ø)
...m/koxudaxi/pydantic/PydanticFieldSearchExecutor.kt 67.44% <60.00%> (ø) 21.00 <3.00> (ø)
...om/koxudaxi/pydantic/PydanticFieldRenameFactory.kt 91.83% <66.66%> (ø) 11.00 <0.00> (ø)
src/com/koxudaxi/pydantic/Pydantic.kt 74.26% <100.00%> (ø) 0.00 <0.00> (ø)
.../com/koxudaxi/pydantic/PydanticIgnoreInspection.kt 100.00% <100.00%> (ø) 6.00 <5.00> (ø)
...om/koxudaxi/pydantic/PydanticParametersProvider.kt 100.00% <100.00%> (ø) 4.00 <4.00> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c2f7fae...3780f54. Read the comment docs.

@koxudaxi koxudaxi changed the title [WIP] Support dataclass with extension point Support dataclass with extension point Apr 9, 2020
@koxudaxi koxudaxi merged commit 5ea90a3 into master Apr 9, 2020
@koxudaxi koxudaxi deleted the support_dataclass_with_extension_point branch April 17, 2020 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant