Skip to content

Commit

Permalink
CHG: Enable YADIF for arm
Browse files Browse the repository at this point in the history
  • Loading branch information
@koying
koying committed May 24, 2016
1 parent 0534d6c commit de5b267
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 13 deletions.
11 changes: 0 additions & 11 deletions xbmc/cores/VideoRenderers/LinuxRendererGLES.cpp
View file
Original file line number Diff line number Diff line change
Expand Up @@ -3309,19 +3309,12 @@ bool CLinuxRendererGLES::Supports(EINTERLACEMETHOD method)
return false;
}

#if (defined(__i386__) || defined(__x86_64__))
if(method == VS_INTERLACEMETHOD_YADIF
|| method == VS_INTERLACEMETHOD_YADIF_HALF
|| method == VS_INTERLACEMETHOD_RENDER_BOB
|| method == VS_INTERLACEMETHOD_SW_FFMPEG
|| method == VS_INTERLACEMETHOD_SW_BLEND
|| method == VS_INTERLACEMETHOD_RENDER_BOB_INVERTED)
#else
if(method == VS_INTERLACEMETHOD_SW_FFMPEG
|| method == VS_INTERLACEMETHOD_SW_BLEND
|| method == VS_INTERLACEMETHOD_RENDER_BOB
|| method == VS_INTERLACEMETHOD_RENDER_BOB_INVERTED)
#endif
return true;

return false;
Expand Down Expand Up @@ -3403,11 +3396,7 @@ EINTERLACEMETHOD CLinuxRendererGLES::AutoInterlaceMethod()
if(m_renderMethod & RENDER_IMXMAP)
return VS_INTERLACEMETHOD_IMX_FASTMOTION;

#if !defined(TARGET_ANDROID) && (defined(__i386__) || defined(__x86_64__))
return VS_INTERLACEMETHOD_YADIF_HALF;
#else
return VS_INTERLACEMETHOD_RENDER_BOB;
#endif
}

CRenderInfo CLinuxRendererGLES::GetRenderInfo()
Expand Down
2 changes: 0 additions & 2 deletions xbmc/cores/dvdplayer/DVDCodecs/Video/DVDVideoCodecFFmpeg.cpp
View file
Original file line number Diff line number Diff line change
Expand Up @@ -412,7 +412,6 @@ unsigned int CDVDVideoCodecFFmpeg::SetFilters(unsigned int flags)
}
}

#if (defined(__i386__) || defined(__x86_64__))
if(flags & FILTER_DEINTERLACE_YADIF)
{
if(flags & FILTER_DEINTERLACE_HALFED)
Expand All @@ -425,7 +424,6 @@ unsigned int CDVDVideoCodecFFmpeg::SetFilters(unsigned int flags)

flags &= ~FILTER_DEINTERLACE_ANY | FILTER_DEINTERLACE_YADIF;
}
#endif

return flags;
}
Expand Down

5 comments on commit de5b267

@wrxtasy
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should shutup those that are moaning and complaining if it works on the Shield or AFTV 👍

@koying
Copy link
Owner Author

@koying koying commented on de5b267 May 25, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, well, full yadif doesn't work for 1080i.
Have to check whether it's a horsepower issue or something else ;)

@wrxtasy
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would have though the Shield would have had the ponies easily to do 1080i.
Yes sounds like some other issue.
On the 2GHz A53 in the S905 C2, YADIFx2 576i deinterlacing sits the CPU's on about 50-70%

@koying
Copy link
Owner Author

@koying koying commented on de5b267 May 25, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems more an issue with doubled framerate, actually. I have to do further tests...

@wrxtasy
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes I came to the exact same conclusion...

Please sign in to comment.