Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Implement GaLore optimizer #228

Merged
merged 18 commits into from
Apr 7, 2024
Merged

Conversation

kozistr
Copy link
Owner

@kozistr kozistr commented Apr 7, 2024

Problem (Why?)

close #224

Solution (What/How?)

  • implement GaLore optimizer

Other changes (bug fixes, small refactors)

N/A

Notes

  • Move GaLoreProject into BaseOptimizer

@kozistr kozistr added dependencies Dependencies feature request Request features labels Apr 7, 2024
@kozistr kozistr self-assigned this Apr 7, 2024
Copy link

codecov bot commented Apr 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (523f140) to head (f2d6f14).

Additional details and impacted files
@@            Coverage Diff             @@
##              main      #228    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files           82        83     +1     
  Lines         5946      6086   +140     
==========================================
+ Hits          5946      6086   +140     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kozistr kozistr merged commit b1b5ed4 into main Apr 7, 2024
4 checks passed
@kozistr kozistr deleted the feature/galore-optimizer branch April 7, 2024 06:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Dependencies feature request Request features size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GaLore: Memory-Efficient LLM Training by Gradient Low-Rank Projection
1 participant