Skip to content
This repository has been archived by the owner on Nov 8, 2021. It is now read-only.

Signature at message start #8

Closed
wants to merge 1 commit into from
Closed

Conversation

pmatas
Copy link

@pmatas pmatas commented Apr 3, 2014

  • This modification puts the signature (i.e. sender name) at the message start.
  • Any separators have to be contained in the signature.
  • While the sender name field in signature configuration has focus, a tooltip with an example result of prepending the signature to the message is displayed.
  • After the first character has been typed into the sender name field, a colon is added to the right of the caret.
  • Message size indicators and message part coloring are modified accordingly.
  • The signature is prepended only if it is not already present at the message text start. Only whitespace is stripped for the purpose of comparison to allow signatures composed entirely of non-alphanumeric characters.
  • Automatic upgrade appends a colon to all non-empty signatures.
  • One localization string for translation has been added.

kparal added a commit that referenced this pull request Apr 23, 2014
Thanks to Petr Matas <petr.matas@seznam.cz>.
Pull request: #8
@kparal
Copy link
Owner

kparal commented Apr 23, 2014

Sorry I haven't responded for so long. I'm quite impressed, the code is very good. (Although I haven't checked the coloring computation part, that seemed too difficult;) and could use a few comments.)

I have done a few simple tweaks, but apart from that, I commit it almost as proposed. Thanks for your work!

Pushed as 48ce1e6.

@kparal kparal closed this Apr 23, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants