Upgrade dependencies, make fields final (#56)

* dependencies upgrade * final fields * Readme
kpavlov · Nov 27, 2018 · 3031633 · 3031633
1 parent 2242fc3
commit 3031633
Show file tree

Hide file tree

Showing 6 changed files with 14 additions and 14 deletions.
diff --git a/README.md b/README.md
@@ -178,10 +178,10 @@ For frequently asked questions check the [FAQ](https://github.com/kpavlov/jreact
 [iso8583]: https://en.wikipedia.org/wiki/ISO_8583
 [iso-examples]: https://github.com/beckerdo/ISO-8583-Examples "Some payments processing examples"
 [j8583-example]: https://krishnarag.wordpress.com/2014/06/18/iso-8583-j8583-java-library/
-[j8583]: https://github.com/chochos/j8583 "Java implementation of the ISO8583 protocol."
+[j8583]: https://bitbucket.org/chochos/j8583 "Java implementation of the ISO8583 protocol."
 [j8583-message-factory]: https://github.com/chochos/j8583/blob/master/src/main/java/com/solab/iso8583/IsoMessage.java
 [jpos]: http://jpos.org 
-[netty]: //netty.io 
+[netty]: https://netty.io 
 
 [Iso8583Client]: https://github.com/kpavlov/jreactive-8583/blob/master/src/main/java/com/github/kpavlov/jreactive8583/client/Iso8583Client.java
 [Iso8583Server]: https://github.com/kpavlov/jreactive-8583/blob/master/src/main/java/com/github/kpavlov/jreactive8583/server/Iso8583Server.java

diff --git a/pom.xml b/pom.xml
@@ -21,10 +21,10 @@
         <project.reporting.outputEncoding>UTF-8</project.reporting.outputEncoding>
         <!-- Versions -->
         <j8583.version>1.12.0</j8583.version>
-        <mockito.version>2.23.0</mockito.version>
-        <netty.version>[4.1.30.Final,4.2)</netty.version>
+        <mockito.version>2.23.4</mockito.version>
+        <netty.version>[4.1.31.Final,4.2)</netty.version>
         <slf4j.version>[1.7.25,1.7.999)</slf4j.version>
-        <spring.version>5.1.1.RELEASE</spring.version>
+        <spring.version>5.1.3.RELEASE</spring.version>
     </properties>
 
     <issueManagement>
@@ -156,7 +156,7 @@
                 <groupId>org.junit</groupId>
                 <artifactId>junit-bom</artifactId>
                 <type>pom</type>
-                <version>5.3.1</version>
+                <version>5.3.2</version>
                 <scope>import</scope>
             </dependency>
         </dependencies>

diff --git a/src/main/java/com/github/kpavlov/jreactive8583/ConnectorConfiguration.java b/src/main/java/com/github/kpavlov/jreactive8583/ConnectorConfiguration.java
@@ -39,7 +39,7 @@ public abstract class ConnectorConfiguration {
     private boolean logSensitiveData;
     private int[] sensitiveDataFields;
     private boolean logFieldDescription;
-    private int frameLengthFieldLength;
+    private final int frameLengthFieldLength;
 
     protected ConnectorConfiguration(Builder builder) {
         addLoggingHandler = builder.addLoggingHandler;

diff --git a/src/main/java/com/github/kpavlov/jreactive8583/client/ClientConfiguration.java b/src/main/java/com/github/kpavlov/jreactive8583/client/ClientConfiguration.java
@@ -9,7 +9,7 @@ public class ClientConfiguration extends ConnectorConfiguration {
      */
     private static final int DEFAULT_RECONNECT_INTERVAL = 100;
 
-    private int reconnectInterval = DEFAULT_RECONNECT_INTERVAL;
+    private int reconnectInterval;
 
     /**
      * @deprecated Use {@link Builder}

diff --git a/src/main/java/com/github/kpavlov/jreactive8583/netty/pipeline/IsoMessageLoggingHandler.java b/src/main/java/com/github/kpavlov/jreactive8583/netty/pipeline/IsoMessageLoggingHandler.java
@@ -27,8 +27,8 @@ public class IsoMessageLoggingHandler extends LoggingHandler {
             36,// track 3
             45// track 1
     };
-    private static char[] MASKED_VALUE = "***".toCharArray();
-    private static String[] FIELD_NAMES = new String[128];
+    private static final char[] MASKED_VALUE = "***".toCharArray();
+    private static final String[] FIELD_NAMES = new String[128];
 
     static {
         try (InputStream stream = Thread.currentThread().getContextClassLoader().getResourceAsStream("com/github/kpavlov/jreactive8583/iso8583fields.properties")) {

diff --git a/src/test/java/com/github/kpavlov/jreactive8583/example/LockDetectionIT.java b/src/test/java/com/github/kpavlov/jreactive8583/example/LockDetectionIT.java
@@ -33,16 +33,16 @@ public class LockDetectionIT {
     private static final int NUM_CLIENTS = 20;
     private static final int NUM_MESSAGES = 100;
     private static final Logger logger = getLogger(LockDetectionIT.class);
-    private static CountDownLatch latch = new CountDownLatch(NUM_CLIENTS * NUM_MESSAGES);
+    private static final CountDownLatch latch = new CountDownLatch(NUM_CLIENTS * NUM_MESSAGES);
     private static ThreadMXBean threadMXBean;
     private static Thread monitoringThread;
-    private static AtomicInteger monitorDeadlockedCount = new AtomicInteger();
-    private static AtomicInteger deadlockedCount = new AtomicInteger();
+    private static final AtomicInteger monitorDeadlockedCount = new AtomicInteger();
+    private static final AtomicInteger deadlockedCount = new AtomicInteger();
     @Autowired
     private Iso8583Server<IsoMessage> server;
     @Autowired
     private ApplicationContext applicationContext;
-    private Iso8583Client[] clients = new Iso8583Client[NUM_CLIENTS];
+    private final Iso8583Client[] clients = new Iso8583Client[NUM_CLIENTS];
 
     @BeforeAll
     public static void beforeAll() {