Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend Makefile #37

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Extend Makefile #37

wants to merge 6 commits into from

Conversation

cyqsimon
Copy link
Contributor

@cyqsimon cyqsimon commented Jan 5, 2023

I've updated the instructions in README.md to use make. This will make building from source somewhat easier for the user (and for packagers like me).

It now also installs shell completion scripts and man pages, which were previously left out of the instructions.

@alerque
Copy link
Contributor

alerque commented Jan 5, 2023

This is certainly an improvement, but it is also doing quite a bit of reinventing the wheel doing a lot of what autotools could/would do. I realize it's a bit obtuse so the answer might be "because I don't know how to build a Rust project with autotools", but if platform support, consistency, and doing the expected thing when installing is desired I'd be happy to contribute the autotools tooling to make that happen. As an example of using autotools to build using Cargo and install completions and such my git-warp-time project is a pretty basic example.

@cyqsimon
Copy link
Contributor Author

@alerque yeah I'm not familiar with autotools at all, and if properly done I'm sure it'll be better than this. If you want to give it a shot go ahead, all I want is to have this whole installation routine simplified.

@alerque
Copy link
Contributor

alerque commented Jan 18, 2023

I'm not sure switching to autotools would count a "simplification", but it would increase the robustness. The surface area that a maintainer would need to touch to, say, add or remove bits from the package would be about the same, but the overall level of tooling complexity would go up a bit. The benefit is that it would work more consistently across platforms as expected and lots of edge cases with paths and dependencies and weird shells and such would be smoothed over so ./configure && make && make install would just work out of the box on more systems.

I guess it's going to be up to @kpcyrd. I can probably contribute the autotools conversion using this as a starting point if that's something they want to see that direction taken for this project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants