Version check improvements

[a-wai]

This PR addresses 2 distinct "issues":

• it fixes Version checks are too strict in 0.5.1 #31 by adding a check on a likely-compatible version in case the exact check fails
• it implements "outdated" reporting and adds a new "compatible" status (for crates not fully up-to-date, but likely compatible according to semver) -- reporting the Debian package version in both cases so it's more obvious/useful to the user

Those are split in 2 separate commits in case you only want to cherry-pick the first part.

[alexanderkjall]

Thanks a lot for your contribution :)

I know that there isn't very good test coverage today, but how do you feel about creating a test that showcases this behavior? It feels like this can be subtle enough to easily break by mistake in the future.

[kpcyrd]

I haven't had time to look into this yet (the last few days both the Reproducible Builds Summit and the Arch Linux Summit kept me quite busy), but I also noticed the current cargo debstatus behavior breaks my workflow and I'm all for having this fixed! :)

[a-wai]

Thanks a lot for your contribution :)

I know that there isn't very good test coverage today, but how do you feel about creating a test that showcases this behavior? It feels like this can be subtle enough to easily break by mistake in the future.

Hmm, I came up with the following test:

    #[test]
    fn check_version_reqs() {
        let mut db = Connection::new().unwrap();
        // Debian bullseye has rust-serde v1.0.106 and shouldn't be updated anymore
        let query = "SELECT version::text FROM sources WHERE source in ($1, $2) AND release='bullseye';";
        let info = db.search_generic(query, "serde", &Version::parse("1.0.100").unwrap()).unwrap();
        assert_eq!(info.status, PkgStatus::Found);
        assert_eq!(info.version, "1.0.106");
        let info = db.search_generic(query, "serde", &Version::parse("1.0.150").unwrap()).unwrap();
        assert_eq!(info.status, PkgStatus::Compatible);
        let info = db.search_generic(query, "serde", &Version::parse("2.0.0").unwrap()).unwrap();
        assert_eq!(info.status, PkgStatus::Outdated);
        let info = db.search_generic(query, "notacrate", &Version::parse("1.0.0").unwrap()).unwrap();
        assert_eq!(info.status, PkgStatus::NotFound);
    }

The thing, it requires network access, so it can work for upstream (this repo), but would have to be patched out for the package to build on Debian's buildd.

[kpcyrd]

Something I've done in cases like this is:

    #[test]
    #[ignored]
    fn check_version_reqs() {
        // ...
    }

Then run both cargo test and cargo test -- --ignored in CI, while Debian would only run cargo test.

[a-wai]

@kpcyrd Thanks for the hint! I just pushed the test as a new commit based on that

[kpcyrd]

Thanks, you now also need to edit .github/workflows/rust.yml to include cargo test -- --ignored :)

    steps:
    - uses: actions/checkout@v2
    - name: Build
      run: cargo build --verbose
    - name: Run tests
      run: cargo test --verbose
    - name: Run tests (online)
      run: cargo test --verbose -- --ignored
    - name: Run debstatus on itself
      run: cargo run -- debstatus

[a-wai]

Done already, using --include-ignored so all tests run in one pass ;)

(unless you prefer to keep those as 2 separate steps?)

[kpcyrd]

Doing them both in once is fine, I wasn't aware there's an option for that :)

[jamessan]

Thanks for improving the version checking! I had noted in #29 (comment) that there were some side-effects, and hadn't gotten time to work on addressing those.