Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support clspv's -constant-args-ubo #30

Closed
kpet opened this issue Oct 25, 2018 · 2 comments
Closed

Support clspv's -constant-args-ubo #30

kpet opened this issue Oct 25, 2018 · 2 comments

Comments

@kpet
Copy link
Owner

kpet commented Oct 25, 2018

Support buffer_ubo argument kinds.
@alan-baker
Copy link
Contributor

I wouldn't mind taking this, just going through my company's process to be able to submit a PR.

@kpet
Copy link
Owner Author

kpet commented Oct 25, 2018 •
edited

Thanks for offering. It should be close to trivial to implement. I've just updated clspv on master so you should have everything. Of interest probably is the fact that I'm in the process of refactoring cvk_mem in preparation of landing some code for image support. This will likely conflict with buffer_ubo support but nothing that should be too hard to resolve either way. Can't assign it but consider it assigned to you.

alan-baker added a commit to alan-baker/clvk that referenced this issue Oct 30, 2018
@alan-baker
Add support for buffer_ubo args
3f708d9 
Fixes kpet#30

* Updated clspv submodule
* Added parsing and processing support for buffer_ubo arg kind
 * Generates uniform buffer
* Added simple test that exercises new buffer type
* Fix compile error on Mac
@alan-baker alan-baker mentioned this issue Oct 30, 2018
Merged
alan-baker added a commit to alan-baker/clvk that referenced this issue Oct 30, 2018
@alan-baker
Add support for buffer_ubo args
8cfb6cc 
Fixes kpet#30

* Added parsing and processing support for buffer_ubo arg kind
 * Generates uniform buffer
* Added simple test that exercises new buffer type
* Fix compile error on Mac
@kpet kpet closed this as completed in #31 Oct 30, 2018
kpet pushed a commit that referenced this issue Oct 30, 2018
@alan-baker @kpet
Add support for buffer_ubo args
1c7584c 
Fixes #30

* Added parsing and processing support for buffer_ubo arg kind
 * Generates uniform buffer
* Added simple test that exercises new buffer type
* Fix compile error on Mac
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kpet @alan-baker