-
-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add total number of connected minions #29
Comments
hello @julioz, What about counting the number of minion using The exporter is passive, it only watches the event queue. So I don't see how we could know that a minion disappeared, except if your are sending requests targeting all minions. But if you do, the Note: where I work, we use another simple active exporter only to "ping" our minions (not open-source):
But this is not always reliable depending on your targets workload: sometimes the minion does not respond to test.ping before the timeout because it was doing something else. |
Got it. Is your intent to keep it passive-only, or is |
The initial intent was to keep it passive-only. But if there is a need, I am not opposed to make My two concerns are:
|
We ended up implementing something similar, but based on a homegrown active salt exporter. Feel free to close this issue if there are no plans to implement similarly in this exporter 👍 |
ok great :) thanks for the feedback. I'll close the issue. |
On every scrape, the exporter should include a gauge metric with the number of connected minions to that master node.
This way we can keep track of new minions connected, but more importantly, when minions disappear.
The text was updated successfully, but these errors were encountered: