Schedule advanced success check #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will mainly be useful for state triggered by a scheduler. Salt behavior for a state executed by a scheduler: - success=true as Salt considers it successfully got the state result - inconsitency: sometimes the global retcode is equal to 0 even if one function of the state failed So, to better know the success of a state executed by a scheduler, we will look for "result" in the "return" field, and use them to generate the global success of the state. This is only applied on the scheduler, as this issue does not seem to be present when states are executed directly.
This is due to a Salt inconsistency.
For a Scheduled Job, sometimes a failing jobs can have either:
- retcode=0
- success=True
- no retcode defined in each function of the state
The most precise way to know the real status is to parse the "result"
field in Event.Return, meaning get the "result" boolean provided in each
function of the state.
For example, if we have the given state:
dummy test:
test.nop:
- name: "nop"
success:
test.succeed_with_changes:
- name: "success"
failed:
test.fail_with_changes:
- name: "failed"
We get the "result", which is a boolean, for the dummy test, success and
failed. If one of them is returns "false", we consider the state failed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to a Salt inconsistency, a failing scheduled job can report to be successful.
For a Scheduled Job, sometimes a failing jobs can have either:
The most precise way to know the real status is to parse the "result" field in Event.Return, meaning get the "result" boolean provided in each function of the state.
For example, if we have the given state:
We get the "result", which is a boolean, for the dummy test, success and failed. If one of them returns "false", we consider the state failed.