-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow specifying root URLs separately from endpoints #92
Comments
I would like to begin working on this, and have a few questions about how you would prefer to have it done. It looks like the most reasonable place to specify it in the config would be in parameters of |
Certainly this should be additional parameters to The “too many parameters” note on Actually, I think it would make sense to have an object (namedtuple or otherwise) that pairs up the |
As of commit 15ba713, there are two new parameters to |
Belated followup: with f78ecfd the ws_base_url is allowed to have a path, which is likely to be useful in reverse proxy configurations. |
Add a configuration option to specify the root URLs explicitly rather than deriving them from the
endpoint
options. This will enable using ShinySDR behind a reverse proxy, port forwarding, or other such configurations.Relatedly, it would be nice to have a standard reverse proxy configuration (e.g. for nginx which I vaguely hear is suitable for this task) that makes ShinySDR use only one port rather than two.
The text was updated successfully, but these errors were encountered: