Allow ShinySDR to function behind a reverse proxy #48
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wanted ShinySDR behind a reverse proxy, and ended up finding some fun stuff with the way it determines the websocket URL. Not sure if you want to accept this, but I figured I'd submit it anyway.
This change basically causes it to set the websocket URI to
ws<s>://<host>/websocket/<path>
ifdocument.location.port
is undefined, as it is when the page is loaded on the default port (80 for http, 443 for https). I put the following in my Apache vhost to make the reverse proxying happen, if you'd like to add it to some documentation somewhere:Also, sorry, my editor appears to have removed all tailing whitespace on every line in the file, which makes the diff look weird. The relevant changes start on line 216.