Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kpt fn render should support out-of-place sink-mode #1412

Closed
droot opened this issue Feb 4, 2021 · 7 comments · Fixed by #2137
Closed

kpt fn render should support out-of-place sink-mode #1412

droot opened this issue Feb 4, 2021 · 7 comments · Fixed by #2137
Assignees
@phanimarupaka
Labels
area/hydrate customer deep engagement p1 size/L 4 day triaged Issue has been triaged by adding an `area/` label
Projects
kpt kanban board

Comments

@droot
Copy link
Contributor

droot commented Feb 4, 2021 •
edited by frankfarzan

Currently kpt fn render supports in-place sink-mode. It should support for out-place and stdout mode.
@droot droot added this to To do in kpt kanban board via automation Feb 4, 2021
@droot
Copy link
Contributor Author

droot commented Feb 4, 2021

/cc @natasha41575 @Shell32-Natsu Feel free to pick this whenever you can.

@mikebz mikebz added the triaged Issue has been triaged by adding an `area/` label label Feb 10, 2021
@Shell32-Natsu Shell32-Natsu self-assigned this Feb 18, 2021
@Shell32-Natsu Shell32-Natsu moved this from To do to In progress in kpt kanban board Feb 18, 2021
@mikebz mikebz moved this from In progress to To do in kpt kanban board Feb 23, 2021
@droot droot added this to the v1.0 alpha 2 milestone Mar 3, 2021
@droot droot changed the title kpt pipeline run should support both sink-mode in-place/out-place/stdout kpt pipeline run should out-of-place sink-mode Mar 3, 2021
@droot droot mentioned this issue Mar 3, 2021
Closed
10 tasks
@droot droot added the size/L 4 day label Mar 3, 2021
@mikebz mikebz modified the milestones: v1.0 m1, v1.0 m2 Mar 30, 2021
@mikebz mikebz added the p2 label Apr 13, 2021
@phanimarupaka phanimarupaka assigned phanimarupaka and unassigned droot Apr 14, 2021
@phanimarupaka
Copy link
Contributor

phanimarupaka commented Apr 14, 2021 •
edited

@droot I can pick this up. Do you mean kpt fn render ? Should we support this now ? I am not sure if this qualifies to be added to m2. I think its cleaner if we just support in-place hydration first, gather feedback and pick this up. kpt fn eval already supports this #1710

cc @mikebz

@phanimarupaka phanimarupaka changed the title kpt pipeline run should out-of-place sink-mode kpt fn render should out-of-place sink-mode Apr 14, 2021
@droot droot changed the title kpt fn render should out-of-place sink-mode kpt fn render should support out-of-place sink-mode Apr 14, 2021
@droot
Copy link
Contributor Author

droot commented Apr 14, 2021

@droot I can pick this up. Do you mean kpt fn render ? Should we support this now ? I am not sure if this qualifies to be added to m2. I think its cleaner if we just support in-place hydration first, gather feedback and pick this up. kpt fn eval already supports this #1710

cc @mikebz

Yes, we do want to support out-of-place mode for kpt fn render. I do agree that it is not highest priority. But being able to dump the output of fn render in a separate directory helps with being able to diff the changes without having to depend on git. Also supporting dumping the output in a separate directory requires very little change in the code.

I will keep this in m2 with low priority for now.

@phanimarupaka
Copy link
Contributor

Ack. I will work on it.

@mikebz
Copy link
Contributor

mikebz commented Apr 22, 2021

I think given that we are now short on resource I suggest we move this out to M3. This is a P2 feature and we should focus on getting a full E2E experience with in place hydration.

@phanimarupaka
Copy link
Contributor

Yes. Moving it to M3.

@phanimarupaka phanimarupaka modified the milestones: v1.0 m2, v1.0 m3 Apr 22, 2021
@phanimarupaka phanimarupaka assigned droot and unassigned phanimarupaka May 7, 2021
@mikebz mikebz added the p1 label May 24, 2021
@mikebz mikebz added customer deep engagement and removed p2 labels May 24, 2021
@natasha41575
Copy link
Contributor

@droot I can pick this up in the next sprint

@natasha41575 natasha41575 assigned natasha41575 and unassigned droot May 25, 2021
@mikebz mikebz moved this from To do to In progress in kpt kanban board May 25, 2021
@natasha41575 natasha41575 moved this from In progress to To do in kpt kanban board May 27, 2021
@phanimarupaka phanimarupaka mentioned this issue May 30, 2021
Merged
@phanimarupaka phanimarupaka moved this from To do to In Review in kpt kanban board May 31, 2021
@phanimarupaka phanimarupaka linked a pull request May 31, 2021 that will close this issue
Out of place hydration using render and eval #2137
Merged
@phanimarupaka phanimarupaka mentioned this issue May 31, 2021
Closed
9 tasks
@phanimarupaka phanimarupaka moved this from In Review to In progress in kpt kanban board Jun 3, 2021
@phanimarupaka phanimarupaka moved this from In progress to In Review in kpt kanban board Jun 4, 2021
@phanimarupaka phanimarupaka moved this from In Review to Done in kpt kanban board Jun 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@phanimarupaka phanimarupaka

Labels
area/hydrate customer deep engagement p1 size/L 4 day triaged Issue has been triaged by adding an `area/` label
Projects
kpt kanban board
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Out of place hydration using render and eval phanimarupaka/kpt
5 participants
@droot @mikebz @Shell32-Natsu @natasha41575 @phanimarupaka