-
Notifications
You must be signed in to change notification settings - Fork 226
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Out of place hydration using render and eval #2137
Conversation
ba3b3ff
to
13f63d5
Compare
This PR is doing too many things, and combines multiple UX changes each deserving their own consideration e.g (Using |
@phanimarupaka Thanks for working on this! 💯 From a cursory look it seems this would indeed unblock the hydration functionality needed for LZ. |
e4ec538
to
5cff579
Compare
5cff579
to
4ab7969
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add the different usages to the reference docs and make sure they have e2e tests. To make this manageable consider splitting into separate PRs, one per command.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did a quick pass of the Go
code only.
4ab7969
to
6664c93
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Second pass only on the Go
code, will review the docs/tests in the morning.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking in good shape, few more comments.
bfb2240
to
94ea38b
Compare
/lgtm with the suggested follow up on non-structured results. Please wait for @droot to approve. |
d01a224
to
b702e0a
Compare
43d1ec1
to
037fe10
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this. This is good to go 🚢
We need to follow up with:
- We need to update the go/kpt-testcases sheet for out-of-place
- non-structructured output to be send to
stderr
always: that will remove conditional printing - Removing Stdin (-) from
fn eval
|
Commit 1:
--output(-o)
flag torender
andeval
commands, to support out of place hydration and writes rendered resources to stdout(stdout wrapped)|unwrap(stdout unwrapped)|OUT_DIR_PATH(to another directory). (kpt fn render
should support out-of-place sink-mode #1412)--dry-run
flag from eval command as it is supported by--output
flag.Commit 2
Add e2e tests for oop hydration
Commit 3
Reference docs.
Supported example
Note:
render
can only read from directory and not STDIN.eval
can read from both stdin and directory.