Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow output path relative to function config file #1531

Open
mgoltzsche opened this issue Mar 7, 2021 · 9 comments
Open

Allow output path relative to function config file #1531

mgoltzsche opened this issue Mar 7, 2021 · 9 comments
Labels
area/hydrate customer deep engagement p2 size/S 1 day triaged Issue has been triaged by adding an `area/` label

Comments

@mgoltzsche
Copy link

mgoltzsche commented Mar 7, 2021

Is your feature request related to a problem? Please describe.

Users expect output paths declared within a function to be relative to the function's config file.
This came up in mgoltzsche/khelm#12

Describe the solution you'd like

kpt should handle function output paths relative to the function config's path when writing the output to disk.

Describe alternatives you've considered

Manage all functions within a root directory and always call kpt fn run . within that directory.

Additional context

See mgoltzsche/khelm#12

cc @howardjohn

@mikebz mikebz added triaged Issue has been triaged by adding an `area/` label area/hydrate labels Mar 10, 2021
@mikebz mikebz added this to To do in kpt kanban board via automation Mar 10, 2021
@mikebz mikebz added the p2 label Mar 10, 2021
@mikebz
Copy link
Contributor

mikebz commented Mar 10, 2021

@droot @mengqiy could be an interesting use case for you to adopt and analyze as you are working on hydration/functions v1. khelm is a solution that is delivered in several ways including a kpt function.

@mikebz mikebz added the customer deep engagement label Mar 10, 2021
@droot
Copy link
Contributor

droot commented Mar 17, 2021

@mgoltzsche we are introducing new primitive called pipeline (part of Kptfile) to run kpt-functions declaratively where each pkg (and subpackage) can have their own pipeline. In the new workflow, output generated by a function will be saved in the pkg that includes the pipeline that invoked that function. I think that should address this requirement.
This is in active development on next branch and will be in shape to be tried out in 2 weeks.

@droot droot added this to the v1.0 alpha 2 milestone Mar 17, 2021
@mgoltzsche
Copy link
Author

Sounds good! Looking forward to playing with that!

@mikebz
Copy link
Contributor

mikebz commented Mar 18, 2021

@droot any chance we can link this issue to the Epic or Feature ticket? That way when it closes we can let @mgoltzsche know?

@mikebz mikebz added the size/S 1 day label Apr 8, 2021
@droot droot modified the milestones: v1.0 m1, v1.0 m2 Apr 13, 2021
@Shell32-Natsu
Copy link
Contributor

@droot Do we have an issue to track how does pipeline handle the resources generated by function or we have implemented it?

@mikebz mikebz modified the milestones: v1.0 m2, v1.0 m3 Apr 27, 2021
@droot
Copy link
Contributor

droot commented May 25, 2021

@mgoltzsche We have introduced new concept called pipeline of functions in Kptfile to run functions declaratively that should address this issue I believe. You can read more details here. If you want to take it for a spin, here is a link to the installation instructions.

@mgoltzsche
Copy link
Author

mgoltzsche commented May 27, 2021

That looks awesome! I'll try to prepare a khelm example with it during the weekend.

@howardjohn
Copy link
Contributor

This may be FUD as I only read the docs and didn't actually get a chance to try it out, but it seems like not being to use Network or volume mounts is going to be a pretty critical issue for khelm?

@mgoltzsche
Copy link
Author

That is true! For this to work with e.g. khelm requires to be able to declare also non-yaml files input.
I had another issue in mind that could solve this but apparently it hasn't been implemented yet: #1151

@mikebz mikebz removed this from the v1.0 m3 milestone Jul 14, 2021
@droot droot added this to the Q3-2021 milestone Aug 24, 2021
@droot droot removed this from the Q3-2021 milestone Nov 3, 2021
@droot droot removed their assignment Feb 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/hydrate customer deep engagement p2 size/S 1 day triaged Issue has been triaged by adding an `area/` label
Projects
None yet
Development

No branches or pull requests

5 participants