Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rollouts: Patch external sync object only when needed #3858

Open
natasha41575 opened this issue Mar 3, 2023 · 1 comment
Open

rollouts: Patch external sync object only when needed #3858

natasha41575 opened this issue Mar 3, 2023 · 1 comment
Assignees
@natasha41575
Labels
area/rollout p1 triaged Issue has been triaged by adding an `area/` label

Comments

@natasha41575
Copy link
Contributor

natasha41575 commented Mar 3, 2023 •
edited
Loading

We are currently patching the external sync object on every reconcile, but this is not necessary. This is applicable to both the Rollout and RemoteSync controllers.

Comment ref: #3850 (comment)
@natasha41575 natasha41575 added triaged Issue has been triaged by adding an `area/` label area/rollout labels Mar 3, 2023
@natasha41575 natasha41575 mentioned this issue Mar 3, 2023
Merged
@droot droot added the p1 label Mar 8, 2023
@natasha41575 natasha41575 self-assigned this Mar 11, 2023
@natasha41575
Copy link
Contributor Author

I believe #3871 covers this for the Rollouts controller - we only update the RemoteSync if the spec has changed - so the remaining task is just in the RemoteSync controller when creating the external sync object.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@natasha41575 natasha41575

Labels
area/rollout p1 triaged Issue has been triaged by adding an `area/` label
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@droot @natasha41575