rollouts: check entire spec when patching remotesync #3871
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
natasha41575
force-pushed
the
rollouts/remotesyncupdate
branch
from
894cea0
to
871f05d
Compare
natasha41575
force-pushed
the
rollouts/remotesyncupdate
branch
from
871f05d
to
d254380
Compare
droot
approved these changes
Mar 10, 2023
| // if the spec of the new RemoteSync object is not identical to the existing one, then an update is necessary | ||
| if !equality.Semantic.DeepEqual(oldRS.Spec, newRS.Spec) { | ||
| oldRS.Spec = newRS.Spec | ||
| return oldRS, true |
There was a problem hiding this comment.
Yes, this seems to be more robust. Infact, it is almost equivalent to (without the roundtrip to server):
newRS := newRemoteSync(...)
// apply newRS using server-side apply where apply is only applicable if there are differences.
client.Apply(newRS)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3846
IMO the most robust way to check if the RemoteSync object needs to be updated is to create a new RemoteSync struct based on the current rollout spec and compare it to the existing RemoteSync object in the cluster. This will be able to withstand changes in the Rollouts/RemoteSync APIs.