Create arm64 binaries for kpt releases #1320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
Also may want to consider supporting ARM in our e2e tests. |
|
@mengqiy We should consider how we should handle the binaries that we are currently pushing to GCS. Ideally I think we want to just push everything to github, so it will be easier for us to get data on the number of downloads. Also, the approach we currently use in the cloud build scripts doesn't really scale.. @runewake2 Yeah, we probably should try to do that, but looks like we need to set up custom runners for github actions to be able to do it. More importantly we should make sure we run the build on macos and windows in addition to linux. |
|
I agree with merging this now and then doing other incremental improvements. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds arm64 arch to goreleaser.
Ref: #1319