Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add .spec.subgroups field in ResourceGroup CRD #1335

Merged
merged 1 commit into from
Jan 15, 2021

Conversation

Liujingfang1
Copy link
Contributor

Add the field .spec.subgroups for child ResourceGroup CRs, which represent sub groups.

/assign @mortent @seans3

@seans3
Copy link
Contributor

seans3 commented Jan 8, 2021

I think we should add more comments in the files to make clear the difference between ResourceGroup subgroup objects and regular inventory objects, but I'm OK with this in general. I'll let Morten comment, and if he's OK with it, we'll merge it.

Copy link
Contributor

@seans3 seans3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@seans3 seans3 merged commit ed05661 into kptdev:master Jan 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants