Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add container runtime for pipeline #1355

Merged
merged 6 commits into from
Jan 25, 2021
Merged

add container runtime for pipeline #1355

merged 6 commits into from
Jan 25, 2021

Conversation

Shell32-Natsu
Copy link
Contributor

close #1334

droot
droot requested changes Jan 13, 2021
View reviewed changes
Copy link
Contributor

@droot droot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Took a quick look. Some early comments.

internal/pipeline/runtime/container.go Outdated Show resolved Hide resolved
internal/pipeline/runtime/container.go Outdated Show resolved Hide resolved
internal/pipeline/runtime/container.go Outdated Show resolved Hide resolved
internal/pipeline/runtime/exec.go Outdated Show resolved Hide resolved
internal/pipeline/runtime/container.go Outdated Show resolved Hide resolved
@Shell32-Natsu Shell32-Natsu linked an issue Jan 14, 2021 that may be closed by this pull request
Implement support for docker function execution #1334
Closed
@Shell32-Natsu Shell32-Natsu changed the title [WIP] add container runtime for pipeline add container runtime for pipeline Jan 14, 2021
droot
droot requested changes Jan 14, 2021
View reviewed changes
internal/pipeline/runtime/exec.go Outdated Show resolved Hide resolved
internal/pipeline/runtime/exec_test.go Outdated Show resolved Hide resolved
@Shell32-Natsu Shell32-Natsu mentioned this pull request Jan 20, 2021
Open
@Shell32-Natsu
Copy link
Contributor Author

@droot @frankfarzan PTAL

@Shell32-Natsu Shell32-Natsu merged commit 7783ab5 into kptdev:next Jan 25, 2021
@Shell32-Natsu Shell32-Natsu deleted the docker-runtime branch January 25, 2021 19:25
@Shell32-Natsu Shell32-Natsu mentioned this pull request Jan 25, 2021
Closed
10 tasks
@Shell32-Natsu Shell32-Natsu restored the docker-runtime branch January 28, 2021 21:55
Shell32-Natsu added a commit that referenced this pull request Jan 28, 2021
@Shell32-Natsu
Revert "add container runtime for pipeline (#1355)"
17f6fda 
This reverts commit 7783ab5.
@Shell32-Natsu Shell32-Natsu mentioned this pull request Jan 28, 2021
Merged
Shell32-Natsu added a commit that referenced this pull request Jan 29, 2021
@Shell32-Natsu
Revert "add container runtime for pipeline (#1355)" (#1404)
6ac3036 
This reverts commit 7783ab5.
frankfarzan pushed a commit to frankfarzan/kpt that referenced this pull request Feb 5, 2021
@Shell32-Natsu @frankfarzan
add container runtime for pipeline (kptdev#1355)
c8fa2b0 
add container runtime for pipeline
frankfarzan pushed a commit to frankfarzan/kpt that referenced this pull request Feb 5, 2021
@Shell32-Natsu @frankfarzan
Revert "add container runtime for pipeline (kptdev#1355)" (kptdev#1404)
74bd488 
This reverts commit 7783ab5.
@Shell32-Natsu Shell32-Natsu deleted the docker-runtime branch February 8, 2021 22:02
frankfarzan pushed a commit to frankfarzan/kpt that referenced this pull request Jun 3, 2021
@Shell32-Natsu @frankfarzan
add container runtime for pipeline (kptdev#1355)
a31aba8 
add container runtime for pipeline
frankfarzan pushed a commit to frankfarzan/kpt that referenced this pull request Jun 3, 2021
@Shell32-Natsu @frankfarzan
Revert "add container runtime for pipeline (kptdev#1355)" (kptdev#1404)
21866f0 
This reverts commit 7783ab5.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@droot droot droot approved these changes

@frankfarzan frankfarzan frankfarzan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement support for docker function execution
3 participants
@Shell32-Natsu @droot @frankfarzan