Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation for ResourceGroup as inventory object (alpha) #1357

Merged
merged 1 commit into from
Jan 20, 2021

Conversation

seans3
Copy link
Contributor

@seans3 seans3 commented Jan 13, 2021

  • Adds link in kpt live command docs to upgrade to ResourceGroup as inventory (alpha). This adds a single line to the publicly accessible kpt documentation.
  • Adds alpha instructions to enable the ResourceGroup as inventory object. This is only accessible from single-line link in publicly accessible kpt documentation.
  • Adds alpha commands related to ResourceGroup as inventory object: kpt live migrate and kpt live install-resource-group. These commands are only accessible from minimally accessible ResourceGroup as inventory alpha instructions.
  • Includes updated kpt live init command docs for ResourceGroup as inventory object (only accessible from minimally accessible alpha instructions documents).

Copy link
Contributor

@frankfarzan frankfarzan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good overall. Some minor comments.


```sh
export RESOURCE_GROUP_INVENTORY=1
kpt live install-resource-group
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We discussed that in a normal flow, kpt live init automatically attempts to install the CRD, and failing that, this is the manual fallback, right? In the case, then you can just show the happy path and have this as an aside.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK. I removed this example to the kpt live install-resource-group. I added an explanation further down that the CRD is normally added as an initial step during kpt live apply. Please let me know what you think.


[kpt live init](./init)

### Troubleshooting and Verifying
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there an error case when running kpt live apply that tells the user to fall back to manual install of CRD? (Related to comment above)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, I used the kpt live apply instead of kpt live install-resource-group to illustrate the error. I added the command to manually install the CRD as the way to fix and verify the error. Please let me know what you think.

site/content/en/reference/live/install-resource-group.md Outdated Show resolved Hide resolved
Apply ResourceGroup custom resource definition to the cluster
-->

**NOTE**: This command is not available unless the `RESOURCE_GROUP_INVENTORY`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worth repeating here and for migrate command that this is only relevant for the alpha feature. Actually use the name of the relevant feature to tie these pages together.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've updated this initial NOTE to include the following:

This is an alpha command for the new ResourceGroup as inventory object
 functionality

Please let me know if this is what you are looking for.

[**ConfigMap**](https://kubernetes.io/docs/concepts/configuration/configmap/)
file (usually **inventory-template.yaml**).

### Examples
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the detailed docs and examples. They're clear and helpful.

@seans3 seans3 force-pushed the alpha-rg-docs branch 4 times, most recently from 8cd098f to b675ee1 Compare January 19, 2021 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants