Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Continue on error test #1370

Merged
merged 2 commits into from
Feb 8, 2021
Merged

Continue on error test #1370

merged 2 commits into from
Feb 8, 2021

Conversation

runewake2
Copy link
Contributor

WIP - please don't merge yet.

quick test case covering #1266

This introduces one test case over kpt live apply where a resource is unable to be successfully applied.

It is expected that

pod result
pod-a succeeds
pod-B fails

Currently both pod-a and pod-B are added to the inventory object. This test expects only pod-a to be added to the inventory object. This means the test currently fails. Leave this PR until that behavior has been merged, some changes may need to occur after that feature has completed.

pod-B has an invalid pod name and should fail to create - because of this failure it should not be added to the inventory object.

@runewake2 runewake2 requested a review from seans3 January 21, 2021 01:07
@seans3 seans3 changed the title WIP: Continue on error test Continue on error test Feb 8, 2021
Copy link
Contributor

@seans3 seans3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@seans3 seans3 merged commit 1a13ac1 into kptdev:master Feb 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants