Fix parsing of repos with .git #1398
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
thanks for a quick fix! Is there a way to add some tests here so we don't regress in case this gets refactored? |
natasha41575
force-pushed
the
ParseDotGitInDirName
branch
from
0d3a17a
to
40e4a28
Compare
natasha41575
force-pushed
the
ParseDotGitInDirName
branch
from
40e4a28
to
32eb5de
Compare
phanimarupaka
approved these changes
Jan 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #1323
Parsing should check that a repository name ends in .git, rather than blindly checking if the package name contains .git anywhere.
E.g.
kpt pkg get https://github.com/GoogleContainerTools/kpt/.github/workflows ./