Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update e2e tests to run on pull/push #1497

Merged
merged 1 commit into from
Mar 1, 2021

Conversation

runewake2
Copy link
Contributor

@runewake2 runewake2 commented Feb 26, 2021

Fixes: #1387

This will cause pushes and pulls against kpt to run 2 copies of our e2e tests against Kubernetes versions 1.16 and 1.17 (versions may be added/removed by modifying the matrix).

Changes to the kpt docs/site will be ignored and not trigger tests.

Test results will appear like this: https://github.com/GoogleContainerTools/kpt/actions/runs/603827646

- tests k8s version 1.16 and 1.17
- run e2e tests on pull or push to master/next
- ignore changes in doc directories
@mortent
Copy link
Contributor

mortent commented Mar 1, 2021

How long does it take to run this test?

@runewake2
Copy link
Contributor Author

~5 minutes per environment (run in parallel). See: https://github.com/GoogleContainerTools/kpt/actions/runs/603827646
Total time to run the check is a bit higher but it is not on the longest path. Our build/test/lint job is the slowest job right now so this should have minimal impact on total CI runtime.

Introducing more tests may change this behavior, but there are other improvements we can make to improve test performance here (we are currently building kpt once per workflow for example #1352).

@runewake2 runewake2 merged commit 23b91a8 into kptdev:master Mar 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable Automated Kpt E2E Tests
2 participants