Add Kpt + Gcloud Image Definition #1553
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into add-kpt-gcloud
mortent
reviewed
Mar 18, 2021
|
In the PR description, can you specify the size of the two container images? |
frankfarzan
suggested changes
Mar 18, 2021
| @@ -0,0 +1,34 @@ | |||
| # Copyright 2019 Google LLC | |||
There was a problem hiding this comment.
For consistency, the existing top-level Dockerfile should be moved to release directory as well. This can be a separate PR
There was a problem hiding this comment.
Ack. Will open that PR after this is merged to avoid conflicts with the merge/squash of this change.
release/gcloud/Dockerfile
Outdated
| COPY . . | ||
| RUN go build -v -o /usr/local/bin/kpt -ldflags="-s -w -X github.com/GoogleContainerTools/kpt/run.version=$KPT_VERSION" ./ | ||
|
|
||
| FROM gcr.io/google.com/cloudsdktool/cloud-sdk:alpine |
There was a problem hiding this comment.
Should probably use a pinned version instead. We don't want to have this change without our explicit consent.
There was a problem hiding this comment.
I've pinned this to 332.0.0-alpine and updated our releasing steps to include updates to the base image versions prior to release.
- Update releasing instructions.
frankfarzan
approved these changes
Mar 18, 2021
mortent
approved these changes
Mar 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See: #1506
This introduces a new container image that includes
gcloudalongside other programs configured withkpt. The image will be released askpt-gcloudinto the same container registry as the kpt container (kpt-dev). The image is based off of gcr.io/google.com/cloudsdktool/cloud-sdk:alpineThis image is significantly larger than the
kptimage already published at gcr.io/kpt-dev/kpt but smaller than the larger general purposecloud-sdkimages that are available withkpt.This PR also updates the kpt releasing README with steps that will allow you to run and validate Cloud Build releases of
kptagainst your local fork.Hardcoded github owner values have been removed from the kpt Goreleaser config to prevent publishing new releases to the
GoogleContainerTools/kptrepo unintentionally. (note: this is still possible with wrong parameters and notes have been included to prevent this as best as possible)