Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add workaround for dependency license scan. #1605

Merged
merged 1 commit into from
Mar 24, 2021

Conversation

runewake2
Copy link
Contributor

This is a workaround for #1604 that adds an explicit exception for github.com/posener/complete.

To recreate the error this is addressing:

go mod vendor
go list -m -json all | grep posener

Because the source of v1 of posener is not in the vendor directory but posener/v2 exists the check will ignore existing safeguards meant to catch this case. The LICENSE does not exist because the dependency doesn't exist.

Looking for Feedback: I was not able to find a more elegant way of solving this. If you know of one we will probably want to use that instead.

This is intended as a short term solution to unblock Kpt releases by specifically excluding the github.com/posener/complete project from the check.

@runewake2 runewake2 requested a review from seans3 March 24, 2021 19:15
Copy link
Contributor

@seans3 seans3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants