Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Go to 1.15 in Releases + Check Licenses CI #1665

Merged
merged 5 commits into from
Apr 5, 2021

Conversation

runewake2
Copy link
Contributor

This introduces a new CI Check that runs the create-licenses.sh script and saves the results for 7 days in a GitHub Artifact for reference. These artifacts can be viewed while available by browsing the GitHub Action job (Example available for next week: https://github.com/runewake2/kpt/actions/runs/709503762). This allows the resulting licenses file to be manually validated if needed. Currently a job failure should not produce an artifact. More info about how artifact uploads work is here.

Additionally Kpt's GitHub Actions and Docker Images used during Cloud Build have been brought into alignment on Go Version. They should all use Go version 1.15 now.

The create-licenses.sh script has been updated to support 1.15.

The new CI check is included to help verify these changes and so licensing issues are detected during the PR's that would introduce them.

Note: This should be merged into kpt next as well. While the workflow file mentions next this is only to keep the workflow definitions identical across branches. This PR should not cause pr's or pushes against next to run this job until it is merged into the next branch.

@runewake2 runewake2 requested a review from seans3 April 1, 2021 21:12
@runewake2 runewake2 merged commit 1143eb6 into kptdev:master Apr 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants