improve kpt fn render error messages #1955
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
natasha41575
force-pushed
the
RenderE2eTests
branch
3 times, most recently
from
1effb75
to
38be6e0
Compare
droot
reviewed
May 11, 2021
e2e/testdata/fn-render/invalid-inline-fnconfig/.expected/config.yaml
Outdated
Show resolved
Hide resolved
frankfarzan
reviewed
May 11, 2021
e2e/testdata/fn-render/invalid-configmap-fnconfig/.expected/config.yaml
Outdated
Show resolved
Hide resolved
e2e/testdata/fn-render/invalid-inline-fnconfig/.expected/config.yaml
Outdated
Show resolved
Hide resolved
|
I have a discussion with @droot and we think probably we can have errors and resolvers for Docker error and validation error and resolve them in top level error handler. |
|
@droot please take a look |
droot
approved these changes
May 12, 2021
e2e/testdata/fn-render/invalid-configmap-fnconfig/.expected/config.yaml
Outdated
Show resolved
Hide resolved
natasha41575
force-pushed
the
RenderE2eTests
branch
from
d7e4527
to
ea51ecf
Compare
natasha41575
force-pushed
the
RenderE2eTests
branch
from
ea51ecf
to
dc65fd1
Compare
|
@phanimarupaka @etefera I am assuming you will take care of the site check issue? Merged this with @droot's permission on that basis; I see the same error in this PR: #1983 |
frankfarzan
pushed a commit
to frankfarzan/kpt
that referenced
this pull request
Jun 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
improve some error messages and add a test no-pipeline-in-subpackage