Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

re-enable gatekeeper test #2398

Merged
merged 1 commit into from
Jul 27, 2021
Merged

re-enable gatekeeper test #2398

merged 1 commit into from
Jul 27, 2021

Conversation

mengqiy
Copy link
Contributor

@mengqiy mengqiy commented Jul 15, 2021

The test was disabled due to unstable output.
It has been fixed.

@mengqiy mengqiy marked this pull request as draft July 15, 2021 20:45
droot
droot reviewed Jul 22, 2021
View reviewed changes
Copy link
Contributor

@droot droot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to update the expected result part for test to pass, otherwise the change is looking good.

@mengqiy mengqiy marked this pull request as ready for review July 26, 2021 21:37
@mengqiy mengqiy merged commit 53b52cd into kptdev:main Jul 27, 2021
@mengqiy mengqiy deleted the reenabletest branch July 27, 2021 00:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@droot droot droot approved these changes

Assignees

@droot droot

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mengqiy @droot