Add Missing file.Close() calls #2761
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Calls to close files were missing in a couple of places
martinmaly
requested review from
droot,
mengqiy,
mortent and
phanimarupaka
as code owners
droot
approved these changes
Feb 8, 2022
| @@ -177,6 +177,7 @@ func GetValidatedFnConfigFromPath(pkgPath types.UniquePath, configPath string) ( | |||
| if err != nil { | |||
| return nil, fmt.Errorf("functionConfig must exist in the current package") | |||
| } | |||
| defer file.Close() | |||
There was a problem hiding this comment.
Nice side effect of turning render code into library :)
So far we never had to care about this because this code was primarily consumed in the CLI code, but now it gets consumed in a long running process so we discover these.
There was a problem hiding this comment.
We found this one because some filesystem implementations are more sensitive to closing files :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calls to close files were missing in a couple of places