Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to latest version of cli-utils #2796

Merged
merged 1 commit into from
Feb 22, 2022

Conversation

mortent
Copy link
Contributor

@mortent mortent commented Feb 15, 2022

This pulls in the latest changes from master in cli-utils. Once there is a new release from cli-utils, we will update this PR to use the release version.

@mortent mortent force-pushed the UpdateToLatestCliUtils branch 2 times, most recently from 6ebf710 to 65e4311 Compare February 18, 2022 04:35
@mortent mortent changed the title [WIP] Update to latest version of cli-utils Update to latest version of cli-utils Feb 18, 2022
@mortent mortent requested a review from droot February 18, 2022 04:37
@Liujingfang1
Copy link
Contributor

@mortent The cli-utils release 0.28.0 is available. Could you please update this PR?

@mortent
Copy link
Contributor Author

mortent commented Feb 20, 2022

@Liujingfang1 This is ready now. It updates kpt to use the latest version of cli-utils, however it does not add the functionality to add the apply status to the RG resource.

@sdowell This makes some changes to how we handle the flags. I see that you made some changes here to make the autocomplete work (#2631). Is there any automatic tests for this or can you tell me how I can verify that I haven't broken anything?

@Liujingfang1
Copy link
Contributor

/lgtm

@mortent mortent merged commit 9bee31b into kptdev:main Feb 22, 2022
@karlkfi
Copy link
Contributor

karlkfi commented Mar 1, 2022

In the future, it would be nice for cli-utils updates to include a feature/fix highlights with user-facing features/fixes, so they make it to the kpt change log.

Here's some highlights for this one (v0.27.0 -> v0.28.1):

  • Add Actuation & Reconciliation status to the ResourceGroup inventory status.
  • Collect and report validation errors from all objects at the same time, not just the first one to fail.
  • Disable the broken namespace inference feature in apply-time-mutation.
    The user must specify the namespace, for namespace-scoped source objects,
    otherwise a validation error will be returned.
  • Stop returning timeout/cancellation as a resource error.
  • Make CyclicDependencyError edge ordering stable/consistent.
  • Update Kubernetes libraries to v1.23.2
  • Remove legacy support for multiple inventory objects with the same inventory id.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants