Include Repo Address in Repository Table #3061
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mortent
approved these changes
Apr 26, 2022
|
This is a bit of an experiment; JsonPath makes it a bit hard to express this so the JsonPath expression seems suboptimal. Not attached to thisone, just an idea how to make the kpt repo get output better. |
martinmaly
commented
Apr 26, 2022
| @@ -42,6 +42,9 @@ spec: | |||
| - jsonPath: .status.conditions[?(@.type=='Ready')].status | |||
| name: Ready | |||
| type: string | |||
| - jsonPath: .spec['git','oci']['repo','registry'] | |||
There was a problem hiding this comment.
We could change the API and instead of repo and registry for Git and OCI respectively, use Address.
It would create inconsistency with Kptfile design so I would not recommend going that route.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.