Heal Comments on Package Resources Update #3084
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
martinmaly
commented
May 4, 2022
martinmaly
commented
- Heal
- Fix golden files & flags
martinmaly
changed the title
|
The solution looks fine and seems to be reusing the functionality in kyaml already used for functions. I see that this can be unexpected for users since we can't distinguish between comments that have been deliberately deleted from what has been unintentionally lost as part of the process. But we can probably look at feedback here and see what we should do. |
mortent
approved these changes
May 6, 2022
|
I agree we'll have to figure out some way to heal comments when the client editor (i.e. UI) drops them but allow for their deletion. Maybe we'll need a flag. I'll merge this and we'll evolve from here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.