Finalizers and OwnerRefs for PackageRevision #3655
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for Finalizers and OwnerReferences for the PackageRevision type. It does this by reusing these fields from the internal PackageRev type to the PackageRevision type from the aggregated APIServer.
There are a few caveats to finalizers for PackageRevisions. Since these can be removed out-of-band from the APIServer, either by deletion of the Repository from Porch or removal of the PackageRevision directly from git/oci. In these cases, there isn't any way for us to honor the finalizers, so the resource will be deleted directly.