Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for "itemprop" in custom hashes #203

Closed
wants to merge 2 commits into from
Closed

Conversation

kpumuk
Copy link
Owner

@kpumuk kpumuk commented Sep 12, 2019

I am not sure how I feel about this change yet. Basically, it starts treating itemprop attribute in a special way, applying itemprop attribute to _ tag:

display_meta_tags(
  og: {
    image: {
       _:       'image.png',
      itemprop: 'image',
      type:     'image/jpeg',
      width:    200,
      height:   {
        _:        200,
        itemprop: 'custom',
      },
    },
  },
)

Closes #198

@kpumuk
Copy link
Owner Author

kpumuk commented Aug 2, 2021

Merged in #227

@kpumuk kpumuk closed this Aug 2, 2021
@kpumuk kpumuk deleted the dmytro/itemprop branch September 16, 2022 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

How to add attributes other than property and content?
1 participant