Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: skip canonical on noindex pages #214

Closed

Conversation

salzig
Copy link
Contributor

@salzig salzig commented Jul 3, 2020

Based on a Comment of John Mueller (Webmaster Trends Analyst at Google) on Reddit

This is also where the guide that you shouldn't mix noindex & rel=canonical comes from: they're very contradictory pieces of information for us. We'll generally pick the rel=canonical and use that over the noindex, but any time you rely on interpretation by a computer script, you reduce the weight of your input

This merge request therefor introduces a configuration for MetaTags that allows us to choose if we want to skip the canonical url on noindex pages, as it could "override" the noindex for that page.

@salzig salzig force-pushed the feat/skip_canonical_on_noindex_pages branch 2 times, most recently from e32562b to 89641c0 Compare July 3, 2020 07:20
@salzig
Copy link
Contributor Author

salzig commented Jul 3, 2020

Formatting Coverage is failing... awesome.

related issue: codeclimate/test-reporter#418

@salzig salzig force-pushed the feat/skip_canonical_on_noindex_pages branch from 89641c0 to 72253d5 Compare July 3, 2020 11:26
@salzig
Copy link
Contributor Author

salzig commented Jul 3, 2020

rebased on top of #215

@kpumuk
Copy link
Owner

kpumuk commented Aug 2, 2021

Merged in #227

@kpumuk kpumuk closed this Aug 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants