Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

strip_tags is breaking special characters. i would use sanitize instead #85

Closed

Conversation

willybaer
Copy link

@momelnyk
Copy link

+1 for merge

@willybaer willybaer changed the title strip_tags is breaking special characters. i would use instead sanitize strip_tags is breaking special characters. i would use sanitize instead May 5, 2015
@alexkravets
Copy link

+1 for merge, right now we have to link to the branch instead

@kle-roy
Copy link

kle-roy commented Oct 25, 2015

+1 for merge, using willybaer's branch too

@irubnich
Copy link

irubnich commented Nov 4, 2015

+1 for merge

@kgorin
Copy link

kgorin commented Nov 23, 2015

@kpumuk Can we get this updated and merged? I could provide tests for this as well.
/cc @willybaer

@kpumuk
Copy link
Owner

kpumuk commented Nov 23, 2015

The main idea was to remove HTML tags, which strip_tags does. I understand the problem with special chars, but the PR as it is now breaks the initial goal, allowing certain HTML tags to pass through. If you would update it to make sure no HTML tags pass through, and add specs - I don't see any reasons why it could not be merged.

@kpumuk
Copy link
Owner

kpumuk commented Nov 23, 2015

And it breaks current specs suite :-)

@kpumuk
Copy link
Owner

kpumuk commented Aug 24, 2016

We pass encode_special_chars: false to Loofah when doing strip_tags now.

@kpumuk kpumuk closed this Aug 24, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants