undo changes to blank #63
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4010 po4 elements
dummy 4th element to satisfy spec
Merged
kputnam
force-pushed
the
master
branch
2 times, most recently
from
e719b6c
to
d81a571
Compare
|
Closing since this was solved with refinements in #72 |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I do not really know why blank is defined (rather than from some standard ruby library), but I do know that reverting this fixes an issue I have been seeing where simply including this gem (without actively using it) causes many of my tests to break with infinite deprecation warnings:
"DEPRECATION WARNING: Passing options to #find is deprecated. Please build a scope and then call #find on it"
and
"DEPRECATION WARNING: Relation#calculate with finder options is deprecated. Please build a scope and then call calculate on it instead."