Add a default browser Open() for UNIX systems

[scfarley]

For UNIX-like systems other than Linux, add a browser Open() call. Keep Linux as-is to continue handling WSL environments.

[kpym]

@scfarley Thanks for your contributions 🙏

It looks like that 'linux' is included in 'unix' (check syslist.go).

So it might be easier to rename browser_linux.go to browser_unix.go ?

Not only does it look simpler, but also I don't know how go prioritizes unix and linux when compiling for linux : if it considers that both files should be used on linux system, this will cause an error (function already defined).

[kpym]

As I suspected, your pull request is not compatible with the other three browser_*.go files because _unix is not a goos selector, i.e. this file is not restricted only to Unix systems.

To make your browser_unix.go available only for Unix systems that are neither linux nor darwin, you have to add the build tag at the top of the file:

//go:build !windows && !darwin && !linux

[scfarley]

Good catch. I updated it to prevent darwin and linux.

[kpym]

Sorry but you have also to prevent windows because as I said '_unix' prevents nothing.

[scfarley]

From syslist.go, it looks like the unix build tag does not include windows. According to go help buildconstraint:

During a particular build, the following build tags are satisfied:
...
"unix", if GOOS is a Unix or Unix-like system.
...

However, you are correct. GOOS=windows go build throws an error. I need to learn how Go makes the decision to consider unix a build tag with //go:build unix but not when using file names.

[kpym]

@scfarley Thanks for your contribution !

[scfarley]

@scfarley Thanks for your contribution !

Thank you for this wonderful tool!