Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add parameter serviceUrl #2

Merged
merged 1 commit into from
Jun 29, 2024
Merged

Add parameter serviceUrl #2

merged 1 commit into from
Jun 29, 2024

Conversation

MonsieurV
Copy link
Contributor

I added a parameter serviceUrl, for letting configure the service base URL.
This is useful when you're developing or when you host you're on version of the compiler services.

The default behavior is still the same.

@kpym
Copy link
Owner

kpym commented Jun 28, 2024

@MonsieurV thanks for your contribution. Do you accept to rename the switch from serviceUrl to simply url because there are no other urls. My proposal is :

	pflag.String("url", "", "The base url for the service. If empty, the default URL is used.")

@kpym
Copy link
Owner

kpym commented Jun 28, 2024

@MonsieurV Two more things.

  1. I prefere to not commit my .gitignore (I have one also) in this repo.
  2. I prefer to keep my .goreleaser.yml as is, including the archives section you commented on.

Thanks in advance.

@MonsieurV
Copy link
Contributor Author

@kpym ok, that's done. I've squashed so the history is kept clean.

@kpym kpym merged commit 26704a9 into kpym:main Jun 29, 2024
@kpym
Copy link
Owner

kpym commented Jun 29, 2024

@MonsieurV Thanks !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants