Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fs.FileSystem incompatible with vfs.FileSystem #7

Closed
gbbr opened this issue May 15, 2015 · 1 comment
Closed

fs.FileSystem incompatible with vfs.FileSystem #7

gbbr opened this issue May 15, 2015 · 1 comment

Comments

@gbbr
Copy link

gbbr commented May 15, 2015

I've been trying to use fs.FileSystem with a current implementation that we have wrapped over vfs.FileSystem from the golang tools library but it has deemed unsuccessful due to the extra Join method in your package.

I was wondering if you know any scenarios where Join might behave differently from path.Join ? If not, would it be fair to remove this as a path joiner seems to not necessarily be part of a FileSystem interface. I might be wrong though. Thoughts?

@gbbr
Copy link
Author

gbbr commented May 16, 2015

We sorted this out using a custom wrapper https://github.com/sourcegraph/rwvfs/blob/master/vfs.go#L127

@gbbr gbbr closed this as completed May 16, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant