prefer filepath.Join() to string concatenation #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This resolves a bug on OSX in lookupDir() where os.GetWd() returned a path with trailing slash and the existing string concatenation yielded 2 consecutive slashes, causing the lookup to fail. I also fixed a few other spots where Join() should be used.
goven would rewrite import paths in existing codebase of the form
/_vendor/src/foo
which is wrong.
Fix relative paths
This fixes a bug introduced in fa2be85.
Fix goven bug
|
👍 |
|
At this point, I strongly recommend using https://github.com/tools/godep instead of goven. It's better in almost every way. Running I've been planning to add a note to this repo directing people to godep instead. |
|
Goven is deprecated. Closing all issues. I'm advising people to use godep instead. |
|
@kr Thx! I guess you are moving on and good luck to you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves a bug on OSX in lookupDir() where os.GetWd() returned a
path with trailing slash and the existing string concatenation yielded
2 consecutive slashes, causing the lookup to fail. I also fixed a few
other spots where Join() should be used.