Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Go 1.15: conversion from int to string yields a string of one rune #65

Closed
eclipseo opened this issue Jul 28, 2020 · 0 comments · Fixed by #66
Closed

Go 1.15: conversion from int to string yields a string of one rune #65

eclipseo opened this issue Jul 28, 2020 · 0 comments · Fixed by #66

Comments

@eclipseo
Copy link
Contributor

Go 1.15 rc1 on Fedora Rawhide

Testing    in: /builddir/build/BUILD/pretty-0.2.0/_build/src
         PATH: /builddir/build/BUILD/pretty-0.2.0/_build/bin:/usr/bin:/bin:/usr/sbin:/sbin:/usr/local/sbin
       GOPATH: /builddir/build/BUILD/pretty-0.2.0/_build:/usr/share/gocode
  GO111MODULE: off
      command: go test -buildmode pie -compiler gc -ldflags "-X github.com/kr/pretty/version=0.2.0 -extldflags '-Wl,-z,relro -Wl,--as-needed  -Wl,-z,now -specs=/usr/lib/rpm/redhat/redhat-hardened-ld '"
      testing: github.com/kr/pretty
github.com/kr/pretty
# github.com/kr/pretty
./formatter.go:40:9: conversion from int to string yields a string of one rune, not a string of digits (did you mean fmt.Sprint(x)?)
FAIL	github.com/kr/pretty [build failed]

See golang/go#32479
eclipseo added a commit to eclipseo/pretty that referenced this issue Jul 28, 2020
@eclipseo
Convert int to string using rune()
3fe7025 
See golang/go#32479

Fix kr#65.

Signed-off-by: Robert-André Mauchin <zebob.m@gmail.com>
@eclipseo eclipseo mentioned this issue Jul 28, 2020
Merged
@kr kr closed this as completed in #66 Jul 29, 2020
kr pushed a commit that referenced this issue Jul 29, 2020
@eclipseo
Convert int to string using rune() (#66)
ead4522 
See golang/go#32479

Fix #65.

Signed-off-by: Robert-André Mauchin <zebob.m@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Convert int to string using rune() eclipseo/pretty
1 participant
@eclipseo