Fix infinite recursion when diffing structs with cycles #58
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unlike
Format
, theDiff
method doesn't detect cycles and goes into infinite recursion on struct with cycles. This PR attempts to fix it with an approach similiar to that offormatter
, although - I think - in case of diff it's enough to detect cycle on just one side of the diff comparision, as the recursion will stop on the cycle on left side, or on actual difference. The test case contains simple reproducers.