Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Desktop file importer #174

Merged
merged 11 commits into from
Aug 25, 2023
Merged

Desktop file importer #174

merged 11 commits into from
Aug 25, 2023

Conversation

kra-mo
Copy link
Owner

@kra-mo kra-mo commented Aug 21, 2023

No description provided.

GeoffreyCoulaud
GeoffreyCoulaud reviewed Aug 24, 2023
View reviewed changes
Copy link
Contributor

@GeoffreyCoulaud GeoffreyCoulaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, some changes should be done, but I can say that the code works as expected.
Don't hesitate to tell me if I'm missing a part of your reasoning in some suggested changes, my voice is not gospel.

src/importer/sources/desktop_source.py Show resolved Hide resolved
src/importer/sources/desktop_source.py Outdated Show resolved Hide resolved
src/importer/sources/desktop_source.py Show resolved Hide resolved
src/importer/sources/desktop_source.py Show resolved Hide resolved
src/importer/sources/desktop_source.py Show resolved Hide resolved
src/importer/sources/desktop_source.py Outdated Show resolved Hide resolved
src/main.py Outdated Show resolved Hide resolved
src/main.py Show resolved Hide resolved
GeoffreyCoulaud
GeoffreyCoulaud approved these changes Aug 25, 2023
View reviewed changes
Copy link
Contributor

@GeoffreyCoulaud GeoffreyCoulaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Greato

@kra-mo kra-mo merged commit 38d47da into main Aug 25, 2023
2 checks passed
@kra-mo kra-mo deleted the desktop-file-importer branch August 25, 2023 19:57
@GeoffreyCoulaud GeoffreyCoulaud mentioned this pull request Aug 25, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GeoffreyCoulaud GeoffreyCoulaud GeoffreyCoulaud approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kra-mo @GeoffreyCoulaud