Fetch on input event instead of keyup event #101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 30, 2023 11:54
Previously we were using the keyup event to decide when to fetch autocomplete results. This approach resulted in us having to declare a list of keys to ignore to avoid unecessary / unintended fetches. Instead of listening for keyup events, we can simply listen for changes to the text in the input field and fetch based on that. This approach allows many forms of input that may not trigger a keyup event. For example right clicking and pasting from clipboard, or tapping a autocorrect suggestion on a mobile device.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Changes the way we fetch results by listening for
inputevents instead ofkeyupevents.Why
Historically Autocomplete has relied on
keyupevents to decide when to fetch results.Text can be submitted in to a field without triggering a
keyupevent, which results in the user not seeing results until they send anotherkeyupevent (for example by adding a space).This behaviour has resulted in issues like #52 (comment), #78, #91, and #100.
Input events are fired when the value of an input field has changed (https://developer.mozilla.org/en-US/docs/Web/API/HTMLElement/input_event), which allows for many different kinds of input methods that may not trigger a keyup event. For example when a user pastes text or selects an auto correct suggestion on mobile.