-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for https endpoints #340
Comments
Looks like this may be what we want here:
Specifying |
seems like the library is not actively developed anymore? Multiple hostnames would be another critical feature, but that also seems to have stalled #106 |
@mattzque I agree with you. I really need #106 and it seems to have stalled. Is there anyone who can inform if the lib is actively developed or not? If it's active, an ETA for #106 changes would be nice. I'm using this lib for something critical, and if it's not being actively developed I have to choose another one. |
@Raphael-C-Almeida would you like to submit a PR for the changes you require? |
The changes are already being developed by people far more competent on grpc and etcd than myself. I'm still learning the lib internals and grpc and if i came up with something nice i will surely submit a PR =]. I really didn't mean to be harsh. I saw that the #106 was moving and stopped on july with unsuccessful Travis build and a merge conflict. And since it's something really useful I'm interested on it's dev stage. I'm not criticizing the lib nor the good will of the contributors, on contrary, it's the best etcd3 lib I could find. My question above was really to know about the current dev state, if it's receiving only maintenance or if it's receiving new features. Please forgive me if my last message sounded like I'm demanding something, that wasn't really my intention. |
I think #106 is pretty stalled, it'd be great if you maybe could pick it up and try to get it into a mergable state. I'm personally not using this library in production at the moment, so it's only receiving basic maintenance from me. New features are welcome, though, and I'm open to adding new maintainers. |
https://github.com/kragniz/python-etcd3/blob/master/etcd3/client.py#L108
As of right now if no certs are provided it's assumed it's an insecure connection. We should be setting the default grpc channel credentials in the event https is present without certs.
Example:
https://github.com/davissp14/etcdv3-ruby/blob/master/lib/etcdv3/connection.rb#L41-L47
The text was updated successfully, but these errors were encountered: