Create insertion_sort.rb #1222
Merged
Create insertion_sort.rb #1222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
khoaxuantu
reviewed
Apr 7, 2024
There was a problem hiding this comment.
Hi @cy-by-side, I have a small comment for this PR, the rest LGTM.
|
|
||
| ### 插入排序 ### | ||
| def insertion_sort(nums) | ||
| n = nums.length() |
There was a problem hiding this comment.
Suggested change
| n = nums.length() | |
| n = nums.length |
krahets
reviewed
Apr 8, 2024
| =begin | ||
| File: insertion_sort.rb | ||
| Created Time: 2024-04-02 | ||
| Author: Cy (3739004@gmail.com) Xuan Khoa Tu Nguyen (ngxktuzkai2000@gmail.com) |
khoaxuantu
approved these changes
Apr 8, 2024
59 tasks
krahets
reviewed
Apr 10, 2024
| ### 插入排序 ### | ||
| def insertion_sort(nums) | ||
| n = nums.length | ||
| # 外循环：已排序区间为[0, i-1] |
There was a problem hiding this comment.
# 外循环：已排序区间为 [0, i-1]
Please ensure the comments consistent with those in Python.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If this pull request (PR) pertains to Chinese-to-English translation, please confirm that you have read the contribution guidelines and complete the checklist below:
If this pull request (PR) is associated with coding or code transpilation, please attach the relevant console outputs to the PR and complete the following checklist: